Skip to content

Fix handleSubmit typings - #715

Merged
erikras merged 1 commit into
final-form:masterfrom
forivall:fix/handleSubmit-types
Jan 21, 2020
Merged

Fix handleSubmit typings#715
erikras merged 1 commit into
final-form:masterfrom
forivall:fix/handleSubmit-types

Conversation

@forivall

Copy link
Copy Markdown
Contributor

Fixes #86

The typescript typings work in my local code - in this case, with a button handler, but it should work in React Native typescript typings as well.

Let me know if the flow typings changes are fine - i did my best 😄 .

@forivall

forivall commented Jan 10, 2020

Copy link
Copy Markdown
Contributor Author

* ugh, sorry about the formatting changes, the precommit hook did that. Let me know if you want me to remove them.

@codecov

codecov Bot commented Jan 10, 2020

Copy link
Copy Markdown

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #715   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/ReactFinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237bc8...9a0308b. Read the comment docs.

@erikras
erikras merged commit ce42986 into final-form:master Jan 21, 2020
@erikras

erikras commented Jan 22, 2020

Copy link
Copy Markdown
Member

Published in v6.3.4.

@lock

lock Bot commented Feb 21, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with Typescript + React native

2 participants