Skip to content

Submit edge case fix - #697

Merged
erikras merged 3 commits into
final-form:masterfrom
gbiryukov:submit-edge-case-fix
Dec 16, 2019
Merged

Submit edge case fix#697
erikras merged 3 commits into
final-form:masterfrom
gbiryukov:submit-edge-case-fix

Conversation

@gbiryukov

Copy link
Copy Markdown
Contributor

see #695

@codecov

codecov Bot commented Dec 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #697   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/useField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add4fcf...387b22f. Read the comment docs.

@erikras

erikras commented Dec 16, 2019

Copy link
Copy Markdown
Member

Wow, what a very edgy case this is! 👍

I've changed your test to use the previously existing <Toggle/> component built for exactly this sort of test. 😄

@erikras
erikras merged commit d90e418 into final-form:master Dec 16, 2019
@erikras

erikras commented Dec 16, 2019

Copy link
Copy Markdown
Member

Great PR, btw.

  • Test that demonstrates the bug ✅
  • Fix with lengthy comment explaining ✅

❤️

@lock

lock Bot commented Jan 15, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jan 15, 2020
@erikras

erikras commented Jan 22, 2020

Copy link
Copy Markdown
Member

Published in v6.3.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants