Fixed destroyOnUnregister bug - #537
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 225 228 +3
Branches 55 55
=====================================
+ Hits 225 228 +3
Continue to review full report at Codecov.
|
|
But if I have dynamic fields this bug still we appear, right? |
Member
Author
|
I might have an idea to avoid that. Stay tuned... |
Member
Author
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523,
but only for initial fields.Because our fields have to register twice on first render, thedestroyOnUnregisterwill naturally destroy the value on first render. This PR fixes the bug for fields that are present on first form render, but will not fix it for new ones added.Update: Works now for all fields, regardless of when they are added.