Skip to content

ES Module support#8

Merged
mukaiu merged 22 commits into
developfrom
esm
Oct 26, 2021
Merged

ES Module support#8
mukaiu merged 22 commits into
developfrom
esm

Conversation

@huan

@huan huan commented Oct 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Link to:

Issues:

  1. There's no ChatOpera export from @chatopera/sdk

Error: src/asker.ts(14,3): error TS2305: Module '"@chatopera/sdk"' has no exported member 'Chatopera'.

See:

https://github.com/wechaty/wechaty-chatopera/blob/45fb0a43e0fbf4e5d19c2cf2c8db19de7f55ada8/src/asker.ts#L12-L15

@huan huan mentioned this pull request Oct 4, 2021
Open
49 tasks
@huan huan requested a review from hailiang-wang October 4, 2021 10:32
@huan

huan commented Oct 4, 2021

Copy link
Copy Markdown
Member Author

@hailiang-wang Please help this PR to fix the ChatOpera import issue, then I will be able to continue working on it.

@huan

huan commented Oct 10, 2021

Copy link
Copy Markdown
Member Author

ping @hailiang-wang

@huan

huan commented Oct 17, 2021

Copy link
Copy Markdown
Member Author

Because the https://github.com/chatopera/chatopera-nodejs-sdk has been disabled the issue function, so I leave the reason here:

After inspecting the source code of @chatopera/sdk, I found that the typing was missing in the index.d.ts file: there's no Chatopera definition at all.

I hope it can be resolved because it is breaking the importing code in the downstream TS programs.

@huan huan mentioned this pull request Oct 17, 2021
Closed
@huan

huan commented Oct 24, 2021

Copy link
Copy Markdown
Member Author

@mukaiu Could you please help us to review this PR, and if it's OK let's move on to merge it?

Thank you very much!

@huan huan requested a review from mukaiu October 24, 2021 03:14
mukaiu
mukaiu reviewed Oct 25, 2021
View reviewed changes
Comment thread src/asker.ts
} from './chatopera'
} from './chatopera.js'

import {

@mukaiu mukaiu Oct 25, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code, need to add file extension.

mukaiu
mukaiu reviewed Oct 25, 2021
View reviewed changes

@mukaiu mukaiu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the latest code to resolve eslint.

@mukaiu mukaiu merged commit 8b4c8f7 into develop Oct 26, 2021
@huan huan deleted the esm branch October 27, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukaiu mukaiu mukaiu left review comments

@hailiang-wang hailiang-wang Awaiting requested review from hailiang-wang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huan @mukaiu