Rename justification settings to just settings#6652
Open
teunbrand wants to merge 6 commits into
Open
Conversation
thomasp85
reviewed
Dec 3, 2025
thomasp85
left a comment
thomasp85
left a comment
Member
There was a problem hiding this comment.
Won't this break every piece of code that uses the old name
Collaborator
Author
|
If the code is building a |
Member
|
Ah - I see now how you deal with the old spelling inside the code... I'm fine with putting this in the code base - if you want we can run a revdepcheck on it before merging? |
thomasp85
approved these changes
Dec 3, 2025
Collaborator
Author
|
Yeah I think a revdepcheck would be wise for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6607.
I'll reiterate that this is just for consistency purposes.
I know from previous revdepchecks that some packages save their themes to objects instead of regenerating them by calling
theme().Other packages have
expect_silent()in their test, which is incompatible with lifecycle changes.Such packages are at risk of being negatively affected.