[WIP] Fix/cookies jar submit #2668#2707
Conversation
|
Hi @Sushanth012, thanks a lot for picking up sub-task 1 from #2668 — the cookie plumbing through check_features_manually looks correct and the regression test is well-scoped. I'd like to land that part 👍 🆒 However, this PR also contains a second, unrelated commit — "Improve graph visualization: dark theme, node info, linking" — which is not mentioned in the title or description and touches ~150 lines in maigret/report.py. Could you please split the PR into two:
Splitting the work makes both changes much easier to review, and lets the cookie fix land immediately while we iterate on the visualization. Thanks again for the contribution! 👍 |
Summary
Fixes the cookie TODO in
maigret/submit.py(line 218), part of #2668.Changes
check_features_manuallynow acceptscookie_filename, loads thecookie jar, filters cookies for both existing and generated URLs,
and passes them into the HTTP comparison calls
get_html_response_to_comparenow forwards optional cookies tosession.gettests/test_submit.pyconfirming thecookie jar is loaded and filtered for both URLs
Closes part of #2668