fix(UI): Fix ad marker alignment regression#10193
Merged
Merged
Conversation
Fixes a UI alignment bug where percentage-based ad markers and interstitials were shifted horizontally. This regression was introduced in PR shaka-project#10097 due to how CSS handles 'background-position' when using percentage values. Now, the seek bar uses color stops within a full-width linear gradient for dynamic percentage markers to guarantee exact boundaries, while preserving the original centering logic for absolute-width chapter markers.
Collaborator
|
Bundle Size Report for PR #10193
|
Collaborator
|
Incremental code coverage: 11.11% |
tykus160
approved these changes
Jun 9, 2026
avelad
added a commit
that referenced
this pull request
Jun 15, 2026
Fixes a UI alignment bug where percentage-based ad markers and interstitials were shifted horizontally. This regression was introduced in PR #10097 due to how CSS handles 'background-position' when using percentage values. Now, the seek bar uses color stops within a full-width linear gradient for dynamic percentage markers to guarantee exact boundaries, while preserving the original centering logic for absolute-width chapter markers.
avelad
added a commit
that referenced
this pull request
Jun 15, 2026
Fixes a UI alignment bug where percentage-based ad markers and interstitials were shifted horizontally. This regression was introduced in PR #10097 due to how CSS handles 'background-position' when using percentage values. Now, the seek bar uses color stops within a full-width linear gradient for dynamic percentage markers to guarantee exact boundaries, while preserving the original centering logic for absolute-width chapter markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a UI alignment bug where percentage-based ad markers and interstitials were shifted horizontally. This regression was introduced in PR #10097 due to how CSS handles 'background-position' when using percentage values.
Now, the seek bar uses color stops within a full-width linear gradient for dynamic percentage markers to guarantee exact boundaries, while preserving the original centering logic for absolute-width chapter markers.