Skip to content
This repository was archived by the owner on Oct 1, 2020. It is now read-only.

fixing pep8 from master branch#680

Open
marcosptf wants to merge 9 commits into
quokkaproject:masterfrom
marcosptf:feature/fixing-pep8
Open

fixing pep8 from master branch#680
marcosptf wants to merge 9 commits into
quokkaproject:masterfrom
marcosptf:feature/fixing-pep8

Conversation

@marcosptf

@marcosptf marcosptf commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

every pr that i've worked, had problems with it, the idea this branch is just fix it from branch master;

pr enable to merge;

Att,
@marcosptf

# TODO: get metadata from database
# TODO: implement libratar/gravatar
# return {
# 'cover': 'foo',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the comet lines

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and created a new issue to dont lost these itens:
#681

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit => d0a448b

Comment thread quokka/core/content/utils.py Outdated
data = content

category_slug_data = data.get('category_slug')
category_data = slugify_category(data.get('category') or '')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: data.get('category', '') maybe it's simpler

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done;
commit => marcosptf@9ab0245

@brenorr brenorr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

This was referenced Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants