Replies: 3 comments
-
|
Ping, anybody have thoughts/info on this please? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
and again ?? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I'd love to hear the response, too. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi there.
First of all, thank you for the very helpful and nicely designed tool that is ddns-updater.
I have been looking into using healthcheck.io, which I self-host a version of on another machine, to monitor the running of ddns-updater. Healthcheck seems to all be setup OK. I can curl the healthcheck endpoint and it gets updated, then if I append a number to the call I can get it into a failed state and am notified.
On the ddns-updater side, I run an up to date version (2.9.0), "bare bone", ie not via docker, on Arch linux, using the AUR package which I maintain https://aur.archlinux.org/packages/ddns-updater. I have the two env variables setup
HEALTH_HEALTHCHECKSIO_BASE_URLandHEALTH_HEALTHCHECKSIO_UUID.However, so far, healthcheck is getting nothing from ddns-updater, and I wonder if this is perhaps by design, and so I have questions about the design.
From reading the codebase, it looks to me like ddns-updater makes a call to healthcheck here:
ddns-updater/internal/update/service.go
Line 373 in b2a446b
If so, then that is not how I understand the basic idea of healthcheck.io, which requires that HEALTHY services systematically and periodically report that they are healthy. What if ddns-updater last had a successful run, but then crashes silently, or hangs for example? I will get no more calls to healthcheck, and will continue to assume that it is in an "OK" state. In the mental model I have of this setup, the healthcheck API should get called on every single run (I'm not sure I understand the code entirely, but possibly on every tick on the "ticker"
ddns-updater/internal/update/service.go
Line 404 in b2a446b
When is ddns-updater supposed to call healthcheck at present? Am I misreading something here? And if I'm not, what do you think of this proposed change? Would that not be a more logical way to set things up ?
Thanks in advance for your time and thoughts,
Best regards,
Mark.
Beta Was this translation helpful? Give feedback.
All reactions