World Module Refactor Questions

[itzrobotix]

Hey! I hope this is the best place to ask questions, please correct me if I'm wrong.

I just wanted to ask a few questions as I noticed you released a refactor of the world module which is awesome. I saw it now supports per dimension gamerules, is that control granular just like the WorldGameRules mod by Drex?
My other question was does the new world module have an import method for an already existing world? Reason being I switched over to Drex's WorldManager and WorldGameRules which are both awesome but if I can limit the amount of separate mods I'm using by taking advantage of functionality built into Fuji that would be ideal for me. I have already pregenerated additional worlds though so I can't just recreate new ones with Fuji. So an import option would be fantastic

Thanks for your time.

[sakurawald]

is that control granular just like the WorldGameRules mod by Drex?
Yes, the new world module does support to configure per-dimension of all game rules. But it does lack some useful commands to configure it conveninently. You have to modify the world.json file, and issue /fuji reload to configure it.

Of course, you can use the world module with WorldGameRules mod, which provides better commands to modify and query the game rules.
Another solution is to used Drex's WorldManager mod and WorldGameRules mod. (In this case, you can just disable the world module)

an import method for an already existing world?

Current there is no a conveninent import command. You have to put your dimension folder into world/dimensions/fuji/<dimension-id> here, and write a config section for that dimension in world.json file. (It requires a re-start to load the dimension, currently we didn't provide a load dimension command, to load a just imported dimensino)

Drex's WorldManager and WorldGameRules which are both awesome but if I can limit the amount of separate mods I'm using by taking advantage of functionality built into Fuji that would be ideal for me.

You can take your preferences. However, fuji is designed to be compatible and fully-modular. If the WorldManager mod and WorldGameRules mod works perfect for you, then you can simply disable the world module, and use them.

So an import option would be fantastic

I will add the load, unload and import command, to support runtime world management. You have to be patient.

[sakurawald]

Issue created #400

[itzrobotix]

Thank you for your response! I will likely switch back over to Fujis implementation of the world handling. Even if for now it's not possible to import my existing worlds, if I can manually move the files to have Fuji register them correctly then that also works for me. I'm very glad to see this refactor, you've been doing some really amazing work with this mod and I'm glad to see it's very actively maintained and improved.

[sakurawald]

if I can manually move the files to have Fuji register them correctly then that also works for me

Fuji doesn't touch the world data itself, that's to say, never writes any data into the world folder.
What it does it simple, when server start-up, the world module will try to load the dimensions defined in world.json file.

The vanilla Minecraft didn't care if a dimension is created or imported, the chunk generator will generate a new chunk if it didn't exists, or use the existed chunk.

To import a dimension folder manually, you have to put it into world/dimensions/fuji/example_name, and add a new config section in world.json.
If may looks like

  "dimension_list": [
    {
      "enable": true,
      "dimension": "fuji:example_name",
      "dimension_type": "minecraft:overworld",
      "seed": <here>
   ...

This is all the import fields to define a chunk generator. You can leave other fields empty, world module will generate a default one for you.

However, I suggest you wait and use the load/import command.

[itzrobotix]

Thank you, in that case I will just wait for the import/load commands to avoid any issues.

[itzrobotix]

Hey, can I just ask. The per dimension implementations for everything do they have fuji command implementations or do they support the vanilla commands for setting? "/gamerule" "/setspawn" etc or can they only be set via config?

And can you use per dimension options for vanilla dimensions? If so how does that work?

[sakurawald]

Hey, can I just ask. The per dimension implementations for everything do they have fuji command implementations or do they support the vanilla commands for setting? "/gamerule" "/setspawn" etc or can they only be set via config?

And can you use per dimension options for vanilla dimensions? If so how does that work?

The fuji didn't touch the vanilla commands like /gamerule, /worldborder and /weather.
However, you can modify then in the config file directly, and issue /fuji reload.
They does support hot reload.
So you can modify the config/fuji/modules/world/border/config.json and config/fuji/modules/world/gamerule/config.json directly, and issue /fuji reload to apply the per-dimension border and per-dimension gamerules.

In internal Minecraft, the World class has a method named getGameRules() and getBorder(), fuji just simply hack the return value of these functions. Other game logics will call these functions to query gamerules and worldborder. This is a simple hack, but it works well. So, it supports the vanilla dimensinos. (That's the reason why I split the world.border and world.gamerule into standalone module, I hope they can be used in vanilla dimensions)

If possible, I want to rename world module into world.manager module, so you have 3 standalone modules named world.manager, world.border and world.gamerule.

[itzrobotix]

Thanks for the explanation!

[itzrobotix]

For the vanilla dimensions, can I just add them into the game rule config and define their game rules in there too. Or do they need to be removed from the blacklist in the main config so Fuji handles them first?

[sakurawald]

For the vanilla dimensions, can I just add them into the game rule config and define their game rules in there too. Or do they need to be removed from the blacklist in the main config so Fuji handles them first?

Actually, the world module should be renamed to world.manager module, to be clear. But it is a historical problem. The world module only does the management of runtime dimension.
The world.border and world.gamerule can be treated as standalone modules. You can just specify the vanilla dimension in the id field.

The blacklist in config/fuji/modules/world/config.json is just a secure option, to prevent the users to issue /world delete minecraft:overworld. (However, in the new versions, I have add the --confirm argument to prevent this)
The blacklist is also a historical thing.

So, just write the minecraft:{overworld/the_nether/the_end} in the config for gamerule and border, and issue /fuji reload.