This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Introduce original_system, original_exec, unbundled_system, and unbundled_exec #7052
Merged
1 commit merged intoMar 27, 2019
Merged
Introduce original_system, original_exec, unbundled_system, and unbundled_exec #70521 commit merged into
original_system, original_exec, unbundled_system, and unbundled_exec #70521 commit merged into
Conversation
Because the previous helpers, `clean_exec` and `clean_system`, use deprecated behavior and thus should be deprecated too.
indirect
approved these changes
Mar 27, 2019
indirect
left a comment
indirect
left a comment
There was a problem hiding this comment.
This seems like the best possible solution to me. 👍
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 27, 2019
7052: Introduce `original_system`, `original_exec`, `unbundled_system`, and `unbundled_exec` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `clean_system` and `clean_exec` would print deprecation messages, but there was not alternative for them. ### What was your diagnosis of the problem? My diagnosis was that the helpers are using deprecated behavior and that we should provide non deprecated alternatives. ### What is your fix for the problem, implemented in this PR? My fix is to introduce `original_system`, `original_exec`, `unbundled_system`, and `unbundled_exec` for consistency with the rest of the helpers, and deprecate `clean_system` and `clean_exec`. ### Why did you choose this fix out of the possible options? I chose this fix because while maybe not super pretty names, they offer an alternative consistent with the other helpers. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Apr 1, 2019
7082: Complete some missing specs r=deivid-rodriguez a=deivid-rodriguez This is a follow up to #7052. ### What was the end-user problem that led to this PR? The problem was that the `Bundle.with_clean_env` & `Bundle.with_original_env` family was missing some deprecation specs, and also the specs were spread out across different files. ### What is your fix for the problem, implemented in this PR? My fix is to add the missing specs, and centralize them in the deprecation specs file. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that the
clean_systemandclean_execwould print deprecation messages, but there was not alternative for them.What was your diagnosis of the problem?
My diagnosis was that the helpers are using deprecated behavior and that we should provide non deprecated alternatives.
What is your fix for the problem, implemented in this PR?
My fix is to introduce
original_system,original_exec,unbundled_system, andunbundled_execfor consistency with the rest of the helpers, and deprecateclean_systemandclean_exec.Why did you choose this fix out of the possible options?
I chose this fix because while maybe not super pretty names, they offer an alternative consistent with the other helpers.