Skip to content

fix/doc-jetson-installation#9633

Merged
ev-mp merged 7 commits into
realsenseai:developmentfrom
tkazik:fix/documentation
Oct 17, 2021
Merged

fix/doc-jetson-installation#9633
ev-mp merged 7 commits into
realsenseai:developmentfrom
tkazik:fix/documentation

Conversation

@tkazik

@tkazik tkazik commented Aug 15, 2021

Copy link
Copy Markdown
Contributor

This PR fixes the installation for jetson, which is currently broken for the second part. It also has some minor editorial changes to enhance readability.

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkazik , thank you for the contribution.
Can you restructure the PR so that the editorial and content changes will be captured in separate commits for review?
Thanks

@tkazik

tkazik commented Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

Besides the fix, 99% of the changes in this PR consists of editorial changes in order to satisfy the markup rules...the diff looks like as if there are many content changes, but this is not the case. You can verify that using the markdown preview in e.g. VS Code.

@ev-mp

ev-mp commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

Well, so please just extract the fix into a separate commit for review.
Searching for a needle in a haystack in not an efficient way to review PRs :)

@tkazik

tkazik commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

alright, so it is now split into 'fix' and 'editorial' changes.

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkazik , thank you for the quick response.
While I think the fix commit is ok the "editorial" change seem to break the layout and exposes the MD syntax, at least in chap#4 and below. See example
image

The first part seem ok,, so if you can refactor it into a separate PR it will be merged promptly.
Thanks

Comment thread doc/installation_jetson.md Outdated

### 2. Establish Developer's Environment

2. **Establish Developer's Environment**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a header. Put double-space or /n to separate from the para below

@ev-mp ev-mp changed the base branch from master to development August 17, 2021 19:15
@tkazik

tkazik commented Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

hm, what exactly is jenkins complaining about?

@ev-mp ev-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkazik , thank you for contribution!

@ev-mp ev-mp merged commit 047829b into realsenseai:development Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants