create rsutils-os.cpp, rsutils-os.h #11830
Merged
Merged
Conversation
Nir-Az
reviewed
May 23, 2023
| @@ -0,0 +1,11 @@ | |||
| // License: Apache 2.0. See LICENSE file in root directory. | |||
| // Copyright(c) 2021 Intel Corporation. All Rights Reserved. | |||
Nir-Az
reviewed
May 23, 2023
| @@ -0,0 +1,47 @@ | |||
| // License: Apache 2.0. See LICENSE file in root directory. | |||
| // Copyright(c) 2022 Intel Corporation. All Rights Reserved. | |||
Nir-Az
reviewed
May 23, 2023
| #pragma once | ||
| #include <string> | ||
|
|
||
| namespace rsutils |
Collaborator
There was a problem hiding this comment.
Please add another child namespace called OS.
namespace rsutils{
namespace os{
...
}
}
SamerKhshiboun
approved these changes
May 23, 2023
Nir-Az
reviewed
May 23, 2023
| @@ -0,0 +1,15 @@ | |||
| // License: Apache 2.0. See LICENSE file in root directory. | |||
Collaborator
There was a problem hiding this comment.
Can we rename to os.h / os.cpp
It will be weird to do this
#include "rsutils/os/rsutils-os.h"
Nir-Az
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move get os_name() and get_platform_name() to rsutils-os