Wait till datanode becomes available during startup#17758
Merged
Conversation
moesterheld
approved these changes
Dec 21, 2023
moesterheld
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thank you.
Only one small comment: Should we add a note to misc/graylog.conf that the two properties are also used for the data node connectivity check?
patrickmann
reviewed
Dec 21, 2023
patrickmann
approved these changes
Dec 21, 2023
janheise
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly as with elastic/opensearch, graylog server now waits for an available datanode. Number of attempts and their delay is configurable, reusing
elasticsearch_version_probe_attemptsandelasticsearch_version_probe_delay, which will be most likely renamed in 6.0.Motivation and Context
Without the waiting logic, users need to start datanode first and then graylog server, otherwise the server immediately crashes with exception.
How Has This Been Tested?
Existing set of unit tests, manually tested starts
Types of changes
Checklist: