Use CPU count to calculate default no. of buffer processors#17737
Merged
Conversation
mpfz0r
approved these changes
Dec 29, 2023
mpfz0r
left a comment
mpfz0r
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
We have quite a few places where we set these defaults.
https://github.com/search?q=org%3AGraylog2%20processbuffer_processors&type=code
We need to check and potentially remove those
bernd
requested changes
Jan 2, 2024
bernd
requested changes
Jan 10, 2024
bernd
left a comment
bernd
left a comment
Member
There was a problem hiding this comment.
Thanks for the update! I have one small comment regarding the changelog. The rest looks good! 👍
Co-authored-by: Bernd Ahlers <bernd@users.noreply.github.com>
bernd
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate default values for process-buffer and output-buffer processors based on the number of CPU cores available to the JVM.
The new defaults will be calculated as illustrated by this graph:
(Highlighted rows represent the predetermined values from #17450.
Fixes #17450
If the number of detected cores is not correct, there are several ways to address that:
-XX:ActiveProcessorCountas a JVM argument, e.g.-XX:ActiveProcessorCount=2--cpusflag, e.g--cpus=2TODO: