Skip to content

DataNode: using hostname as node name default#17025

Merged
janheise merged 10 commits into
masterfrom
datanode/use-hostname-as-nodename-if-not-set
Oct 24, 2023
Merged

DataNode: using hostname as node name default#17025
janheise merged 10 commits into
masterfrom
datanode/use-hostname-as-nodename-if-not-set

Conversation

@janheise

@janheise janheise commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Description

Use the hostname as the default if no node name was explicitly set in the configuration.

fixes #17005

needs backport to 5.2

/nocl

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise marked this pull request as ready for review October 20, 2023 08:49
@janheise janheise requested a review from todvora October 20, 2023 08:49
@janheise janheise marked this pull request as draft October 20, 2023 11:18

@todvora todvora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janheise janheise marked this pull request as ready for review October 23, 2023 11:22
@janheise janheise merged commit d709ae8 into master Oct 24, 2023
@janheise janheise deleted the datanode/use-hostname-as-nodename-if-not-set branch October 24, 2023 09:01
janheise added a commit that referenced this pull request Oct 26, 2023
janheise added a commit that referenced this pull request Oct 26, 2023
janheise added a commit that referenced this pull request Nov 2, 2023
* using the hostname as the default node-name, if none was specified explicitly

* using the hostname as the default node-name, if none was specified explicitly

* using the hostname as the default node-name, if none was specified explicitly

* nodeName is either set explicitly in the conf file or will be the result of the hostname setting otherwise

* small refactoring

* added missing changelog for pr #17025
janheise added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataNode: node_name should consider hostname configuration

2 participants