Store: always call composeConfigs in setProjectAnnotations#18916
Merged
Conversation
yannbf
added
bug
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Aug 17, 2022
Store: always call composeConfigs in setProjectAnnotations
3 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
The testing utilities were only calling composeConfigs in case the project annotations providade were an array, which is wrong given that
composeConfigsprovides sensible defaults which are necessary inprepareStory.This is needed for #18673 to work correctly with the testing utilities
How to test
If your answer is yes to any of these, please make sure to include it in your PR.