replace get_config_var() with get_config_vars() in setup.py.#274
Merged
Conversation
Member
|
Thanks, I'll wait for the Travis builds to finish before merging (there were some issues with Travis cache so I had to restart the build). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_config_var() is deprecated since Python3, and it causes a warning:
warnings.warn('SO is deprecated, use EXT_SUFFIX', DeprecationWarning, 2)If we change to
get_config_vars().get("SO"), it would be compatible with both Python2 and Python3. So why not :-)