cmd/evm: rename t8n args to improve clarity when tracing#23934
Merged
Conversation
Contributor
|
Yeah, this is obviously the preferred approach, and we would have done that if we weren't so averse to making API changes. The "proper" way to do this is to have both flags in parallel for a while, and print an error message when the deprecated ( |
f6b7759 to
95b2a38
Compare
Member
Author
|
Good point @holiman. I added the flags back and marked them as deprecated. I also decided to return an error if the flags are used in a conflicting manner. Not sure you handle situations in the past, but I can remove if you prefer. |
Contributor
|
Please add a printout whenever the deprecated flag is used, telling the user to use the new format instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologizes for another PR - my new commits weren't coming through in #23933.
Okay I misunderstood the meaning of the args
tracer.nomemoryandtracer.noreturndata. I understand now that it is preferred that memory and return data are not printed by default. Given this, I think the flag name are confusing. I didn't realize until looking deeply into this that--tracer.nomemory=falseis a valid argument. I would've assumed the flag did not take a value and was a simple on/off switch, and therefore assumed the correct default behavior for these values should be on. Others have also encountered this.For these reasons, I propose renaming them to
tracer.memoryandtracer.returndatato avoid the double-negative flagtracer.nomemory=false.