'; }
Bug 294808 - Mk/Uses/meson.mk: Define setup during configure stage
Summary: Mk/Uses/meson.mk: Define setup during configure stage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-26 09:33 UTC by Daniel Engberg
Modified: 2026-04-28 18:33 UTC (History)
2 users (show)

See Also:


Attachments
Patch for meson.mk (360 bytes, patch)
2026-04-26 09:33 UTC, Daniel Engberg
no flags Details | Diff
Patch for meson.mk with safeguard (835 bytes, patch)
2026-04-26 20:21 UTC, Daniel Engberg
no flags Details | Diff
Fix ports using CONFIGURE_ARGS instead of MESON_ARGS (6.61 KB, patch)
2026-04-26 23:12 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 09:33:38 UTC
Created attachment 270135 [details]
Patch for meson.mk

Warning has been around for months, just fix it. This also works using muon
Comment 1 Gleb Popov freebsd_committerfreebsd_triage 2026-04-26 09:34:52 UTC
LGTM.
Comment 2 commit-hook freebsd_committerfreebsd_triage 2026-04-26 10:05:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aa8b487719575cb75c4d960baf19e8c99d82d725

commit aa8b487719575cb75c4d960baf19e8c99d82d725
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2026-04-26 10:01:17 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2026-04-26 10:01:22 +0000

    Mk/Uses/meson.mk: Silence warning during do-configure stage

    Add setup to CONFIGURE_ARGS to silence following warning:
    "WARNING: Running the setup command as `meson [options]` instead of
    `meson setup [options]` is ambiguous and deprecated."

    PR:             294808
    Reviewed by:    desktop (arrowd)

 Mk/Uses/meson.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 10:05:21 UTC
Thanks
Comment 4 Dimitry Andric freebsd_committerfreebsd_triage 2026-04-26 16:12:04 UTC
Could it be that after this commit, I now get several ports that error out with:

===>   shared-mime-info-2.4_2 depends on shared library: libintl.so - found (/usr/local/lib/libintl.so)
===>   shared-mime-info-2.4_2 depends on shared library: libxml2.so - found (/usr/local/lib/libxml2.so)
===========================================================================
=======================<phase: configure      >============================
===== env: NO_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>  Configuring for shared-mime-info-2.4_2
usage: meson [-h]
             {setup,configure,dist,install,introspect,init,test,wrap,subprojects,rewrite,compile,devenv,env2mfile,reprotest,format,fmt,help}
             ...
meson: error: unrecognized arguments: _build
===>  Script "configure" failed unexpectedly.
Please report the problem to desktop@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/misc/shared-mime-info/work/shared-mime-info-2.4/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1
Comment 5 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 16:16:47 UTC
(In reply to Dimitry Andric from comment #4)
It's been reverted for now, there are a handful of ports that (incorrectly) uses CONFIGURE_ARGS instead of MESON_ARGS which causes issues. A new attempt and fix is in the works.
Comment 6 Dimitry Andric freebsd_committerfreebsd_triage 2026-04-26 16:50:18 UTC
(In reply to Daniel Engberg from comment #5)
Thanks! I'll update my ports tree then. :)
Comment 7 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 20:21:16 UTC
Created attachment 270158 [details]
Patch for meson.mk with safeguard

Add check so ports don't use CONFIGURE_ARGS incorrectly and causing build failures
Comment 8 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 20:21:32 UTC
Revisit this again...
Comment 9 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 23:12:16 UTC
Created attachment 270167 [details]
Fix ports using CONFIGURE_ARGS instead of MESON_ARGS
Comment 10 Daniel Engberg freebsd_committerfreebsd_triage 2026-04-26 23:13:27 UTC
This now works as intended and affected ports now builds
Testing using Poudriere, FreeBSD 14.4-RELEASE (amd64)
Comment 11 commit-hook freebsd_committerfreebsd_triage 2026-04-28 18:27:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf193dc1da282c769d3291817a8378adbd762ac7

commit bf193dc1da282c769d3291817a8378adbd762ac7
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2026-04-28 18:16:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2026-04-28 18:22:54 +0000

    */*: Replace CONFIGURE_ARGS with MESON_ARGS

    Meson based ports that uses CONFIGURE_ARGS "works" as MESON_ARGS is
    appended however framework and documentation expects that MESON_ARGS
    is used for Meson based ports

    PR:             294808
    Approved by:    blanket

 audio/jack-example-tools/Makefile             |  2 +-
 benchmarks/glmark2/Makefile                   |  2 +-
 deskutils/virt-manager/Makefile               |  2 +-
 graphics/gexiv2/Makefile                      |  2 +-
 graphics/gexiv2_016/Makefile                  |  2 +-
 graphics/libchamplain/Makefile                |  2 +-
 graphics/libdrm/Makefile                      |  2 +-
 graphics/shotwell/Makefile                    |  4 ++--
 misc/shared-mime-info/Makefile                |  2 +-
 multimedia/gstreamer1-plugins/Makefile.common | 19 +++++++++----------
 net-im/libaccounts-glib/Makefile              |  2 +-
 net-im/libsignon-glib/Makefile                |  2 +-
 12 files changed, 21 insertions(+), 22 deletions(-)
Comment 12 commit-hook freebsd_committerfreebsd_triage 2026-04-28 18:27:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=70718cbf1b0089043c9278c6b5f578fadcdf9b9d

commit 70718cbf1b0089043c9278c6b5f578fadcdf9b9d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2026-04-28 18:09:42 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2026-04-28 18:22:33 +0000

    Mk/Uses/meson.mk: Silence warning during do-configure stage

    Add setup to CONFIGURE_ARGS to silence following warning:
    "WARNING: Running the setup command as `meson [options]` instead of
    `meson setup [options]` is ambiguous and deprecated."

    While at it add a safeguard when CONFIGURE_ARGS is used instead of
    MESON_ARGS

    PR:             294808
    Reviewed by:    desktop (arrowd), previous interation

 Mk/Uses/meson.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)