Hi Maintainer Would you update dns/ddclient to v4.0.0? Because it included my reported & fixed bug ChangeLog: https://github.com/ddclient/ddclient/releases/tag/v4.0.0 Thanks you very much.
Created attachment 267424 [details] dns/ddclient: update to v4.0.0 I've got a draft version of a patch attached. I've got it running locally and propose that I run it locally for a week, and let others run it and comment on it. In the past some ddclient upgrades have not been smooth. One important change is that the location of the configuration file will change from /usr/local/etc/ to /usr/local/etc/ddclient/ so it will need an entry in UPDATING. As best I can tell this config file move is necessary: https://github.com/ddclient/ddclient/issues/788 I think the Digest::SHA dependency is covered by the available perls in ports.
Hi mjl@luckie.org.nz Thanks your draft version patch very much. I had patched into my ports tree, build/install and run, result work fine. Result @ ifconfig: inet6 fe80::82b:af3c:9506:4847%ng0 prefixlen 64 scopeid 0x5 inet6 2001:b011:a407:8079:82b:af3c:9506:4847 prefixlen 64 autoconf pltime 3600 vltime 86400 <- Took it into dns/bind920 @ Your patched v4.0.0 + usev6=ifv6, expected result (bug @ v3.11.2) inet6 2001:b011:a407:8079:d2f1:aaae:ac72:51 prefixlen 64 deprecated autoconf temporary pltime 0 vltime 32153 inet6 2001:b011:a407:8079:b7b:8b05:26a4:a75e prefixlen 64 autoconf temporary pltime 3600 vltime 86400 <- Took it into dns/bind920 @ Original v3.11.2 + my filter cmd. Would you update suitable Status of bug or me? Thanks you very much.
(In reply to mjl from comment #1) Is it oK? Can I commit?
1. Use ${ETCDIR} instead of ${PREFIX}/etc/ddclient. 2. Why: @${REINPLACE_CMD} -e 's|%%ETCDIR%%|${PREFIX}/etc| ; \ s|%%LOCALBASE%%|${LOCALBASE}|' ${WRKSRC}/ddclient.in Why not: SUB_FILES+=ddclient ? 3. dns/ddclient/files/ddclient.in and dns/ddclient/files/ddclient_force.in have: required_files="%%PREFIX%%/etc/${name}.conf" but config file installs in: required_files="%%ETCDIR%%/${name}.conf"
Created attachment 267480 [details] v1 All my suggestions are in the patch. In the previous comment I mixed up the files a little.
Created attachment 267481 [details] v2 Move install DOCS to do-install-DOCS-on.
I'm running your v2 patch and it seems fine. You can commit. Please add an UPDATING entry along these lines: 20260126: AFFECTS: users of dns/ddclient AUTHOR: mjl@luckie.org.nz dns/ddclient has been updated to v4.0.0. This release moves the default configuration file location from /usr/local/etc/ to /usr/local/etc/ddclient/. Please move your existing ddclient.conf to the new location before restarting ddclient. See details at https://github.com/ddclient/ddclient/releases/tag/v4.0.0
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5a132e3b9a8382c7ebdccf876c728f6f34d31e40 commit 5a132e3b9a8382c7ebdccf876c728f6f34d31e40 Author: mjl <mjl@luckie.org.nz> AuthorDate: 2026-01-25 20:11:25 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-01-25 20:11:25 +0000 dns/ddclient: Update 3.11.2 => 4.0.0 Changelog: https://github.com/ddclient/ddclient/releases/tag/v4.0.0 This release moves the default configuration file location from /usr/local/etc/ to /usr/local/etc/ddclient/. Please move your existing ddclient.conf to the new location before restarting ddclient. - Fix warnings from portclippy. - Parametrize ddclient with PORTNAME. - Simplify and optimize do-install. - Move docs installation to do-install-DOCS-on. PR: 292669 Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org> UPDATING | 12 ++++++++ dns/ddclient/Makefile | 31 ++++++++++---------- dns/ddclient/distinfo | 6 ++-- dns/ddclient/files/ddclient.in | 2 +- dns/ddclient/files/patch-configure.ac | 6 ++-- dns/ddclient/files/patch-ddclient.in | 55 +++++++++++++++++------------------ dns/ddclient/files/pkg-message.in | 2 +- dns/ddclient/pkg-plist | 2 +- 8 files changed, 62 insertions(+), 54 deletions(-)
Thanks.
Thanks all very much.