Created attachment 267043 [details] git patch file to update port 1) Update to latest version. 2) Take maintainership. 3) Remove PF support from FreeBSD 15.0 onwards, as it no longer works. (patches greatfully received!)
WITHOUT_SYMUX, WITHOUT_RRD, WITHOUT_SYMON - these are all options as they were done 20+ years ago: https://cgit.freebsd.org/ports/tree/sysutils/symon/Makefile#n23 https://cgit.freebsd.org/ports/commit?id=42be62beba4ae1a5f4aec2788c0ca0c7e8c173fb Please convert them into port options: OPTIONS_DEFINE= SYMON SYMUX OPTIONS_DEFAULT= SYMON SYMUX and etc. If you need help with this, I can help. Also fix warnings from portclippy.
Ah yes, you're right. Sorry, I should have looked over the makefile to get it up to code. I'll get back to you shortly. Cheers
(In reply to Jamie Landeg-Jones from comment #2) Friendly ping.
Sorry for that delay. Here is the updated patch. I hope it's ok! Cheers, Jamie 1) Update to 2.90 2) Take maintainership. 3) Remove PF support from FreeBSD 15.0 onwards, as it no longer works. (patches greatfully received!) 4) Turn the WITHOUT_SYMUX, WITHOUT_SYMON into options. 5) Silence portclippy and portformat 6) Fix license 7) Update "UPDATING"
Created attachment 268318 [details] git patch file to update port
Created attachment 268319 [details] Patching to UPDATING Sorry, I forgot to attach this. If you don't think it's needed, that's fine with me, but just in case, here is a patch to UPDATING. Again, sorry for the massive delay with getting back to you. Please let me know i there are still problems Cheers, Jamie
Created attachment 268335 [details] v1 Check my patch. :-)
Created attachment 268350 [details] v2 Make config "samples".
(In reply to Vladimir Druzenko from comment #8) Ahhh, thank-you for your continued patience, and fixing my other errors. Though in my defence, I did pass portclippy, and the tab format was what "portfmt" provided! :-) Good call on the .sample config files too. Sorry I missed that, and the VARS_xxx functionality - I did look for something like that but couldn't find it. I notice that there was another update to the port just an hour or so after I synced my ports tree .. Bad timing there! - Do we need to add a PORTREVISION because of that? Finally, I noticed another error of mine: # Until someone can update sm_pf.c to use the nvlist variants, remote it # from FreeBSD 15 installs, as it no longer works due to the removal of "remote" should be "remove" Otherwise, it's all looking good. Apologies again for the errors.
You're right - the changes are such that PORTREVISION needs to be bumped. What other changes are you planning? I can wait a few hours.
Perhaps I misunderstood you and no additional changes are planned.
BTW, why did you changed LICENSE_NAME?
This is "The 2-Clause BSD License": https://en.wikipedia.org/wiki/BSD_licenses https://opensource.org/license/bsd-2-clause
The only other change was just renaming "remote" to "remove". I didn't actually change the LICENSE stuff - it didn't exist on the original port, so I added it - although his license looked like the BSD license, it didn't actually mention it, so I played safe. What happened is that the update by Robert ( https://git.freebsd.catflap.org/ports/latest/commit/sysutils/symon?id=1bce1ad51958386167678e11a6369300fbd13a52 ) also added the license, as the BSD2CLAUSE license. If that's correct, that's fine by me - if I'd been working off the Makefile after his changes, I'd not have altered the License stuff at all, but I did a portupdate about an hour or so before he made his updates, so I was working off the previous Makefile with no License information.
(In reply to Vladimir Druzenko from comment #13) Sorry, out messages crossed. Ah yes, that looks the same. Sorry. I'd expected his license to mention it's the BSD2CLAUSE, but as it didn't, and I couldn't find any reference to the license other that pointing to his license file, I played safe. IANAL!! :-) But yeah, putting it as bsd2clause is fine!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b98dccb9351011b852d603905dab1968f3af8585 commit b98dccb9351011b852d603905dab1968f3af8585 Author: Jamie Landeg-Jones <jamie@catflap.org> AuthorDate: 2026-02-26 20:45:53 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-02-26 21:26:46 +0000 sysutils/symon: Improve port, take maintainership - Convert to modern OPTIONS. - Add record to UPDATING about options. - "Samplefy" configs. - Fix warnings from portclippy. - "Unbreak" on 15+ - disable PF support (patches gratefully received!). PR: 292366 Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org> UPDATING | 7 +++ sysutils/symon/Makefile | 103 ++++++++++++++++++++++-------------- sysutils/symon/files/pkg-message.in | 14 +++-- sysutils/symon/pkg-plist | 6 +-- 4 files changed, 78 insertions(+), 52 deletions(-)
Thanks.
Thanks, and thanks again for your patience and help!
Sorry for interfering with this patch. I must have somehow missed it when I prepared ports 1bce1ad51958386167678e11a6369300fbd13a52.
No worries, Robert. My fault for sitting on this for about 6 weeks, and then coincidentally picking it up again around the same time as your update!