Created attachment 266612 [details] Patch for tmux Drop tmux-bash-completion, repo archived upstream and is now part of bash-completion [1] While at it adjust port Makefile to follow porters handbook and tree in general more closely Compile and runtime tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist) Poudriere testport OK 13.5-RELEASE (amd64) Poudriere testport OK 13.5-RELEASE (i386) Poudriere testport OK 14.3-RELEASE (amd64) 1: https://github.com/imomaliev/tmux-bash-completion
Thanks for this. I'm pasting the same comment I added to bug #291267. It's fine to remove the bash completions, but we should aim for POLA for bash users. The simplest approach would be to add a pkg-message informing users who want the completions to install the shells/bash-completion package. I guess some people will be unhappy about having to install an omnibus bash completions port just for tmux. An alternative would be to create something like shells/tmux-bash-completions. (It would be nice to have subpackages for this.) I'm fine with these changes, except the reordering of CONFLICTS_INSTALL/ONFIGURE_ARGS. portclippy generally does a good job of checking compliance with the Porter's Handbook. It was happy before, but now it flags ordering issues. Could you share a new diff that addresses both the POLA and reordering concerns?
Portclippy is a static analyzer, it's just a tool. Historically and commonly we've placed CONFIGURE_ARGS or the counterparts for CMake, Meson etc for readability and convenience just above OPTIONS as they normally touches on those switches instead of having to jump back and forth. Feel free to modify the patch as you see fit. Regarding shells/bash-compilation, the amount of work vs benefit of granuality seems very low in terms of actual value.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5c13992c8cfa5fc5e18cc259b22e469f424bd060 commit 5c13992c8cfa5fc5e18cc259b22e469f424bd060 Author: Joseph Mingrone <jrm@FreeBSD.org> AuthorDate: 2026-01-03 19:06:35 +0000 Commit: Joseph Mingrone <jrm@FreeBSD.org> CommitDate: 2026-01-05 03:10:55 +0000 sysutils/tmux: Update to 3.6a Based on a patch from diizzy. See PR 292007. Release notes: https://github.com/tmux/tmux/releases/tag/3.6a PR: 292007 Sponsored by: The FreeBSD Foundation sysutils/tmux/Makefile | 35 ++++++++-------------------- sysutils/tmux/distinfo | 8 +++---- sysutils/tmux/files/patch-server-fn.c (gone) | 24 ------------------- sysutils/tmux/pkg-message | 5 ++++ 4 files changed, 18 insertions(+), 54 deletions(-)
Modifications: 1. DISTVERSION cannot be used here; it results in PORTVERSION=3.6.a, which is interpreted as a pre-release. % pkg version -t 3.6_1 3.6.a > 2. Added a pkg-message to address the POLA concern discussed above. 3. With the removal of the bash completions, only a single license remains, so s/LICENSE_FILE_ISCL/LICENSE_FILE/. 4. Use PATCH_WRKSRC for all files patched during post-patch. 5. Minor no-op formatting changes.